Watchdogs on drupal.org know their job :)
Recently I had a problem in one of the projects i am working: after upgrade of the Workflow module from 6.x-1.0-rc3 to 6.x-1.1, the workflow form on node edit form was not functioning correctly. I was constantly getting php error when saving nodes:
warning: array_key_exists() [function.array-key-exists]: The first argument should be either a string or an integer in …../sites/all/modules/workflow/workflow.module on line 270.
After looking in some other active issues in workflow module, I could not find a solution, so I've done some quick debugging and basic diff searches. And I found the problem - one uninitialized variable, because one line has been deleted in workflow.module (revision 1.75):
$name = check_plain(workflow_get_name($wid));
So after returning erased line in 6.x-1.1 everything was working correctly. Happy :)) with my new fix and detective work I could not wait to go to the workflow issue page and create a new issue where I described the bug and my solution, in the hope that someone will notice it.
Well, that has happened – 7 minutes after my post, user jvandyk posted the link to a duplicated issue (OK, I have noticed this issue, only that I just did not found it worth of reading, because the title was for me a bit misleading).
At the end, I only have to say: it is nice to know that there is someone in Drupal community watching over essential modules like the workflow with that kind of accuracy and speed (OK, John VanDyk is also a guy with fantastic reputation). And for me, I have learned again that important lesson again: always do your homework properly.
tags
Recent blog posts
- CAPTCHA AFTER module released!
- Drupalcamp Timisoara/Romania
- That annoying human spammers - Simple Solution for Spam in Drupal
- Web Community Examples (drupalcamp.at) slides
- Securing your Drupal site - slides from drupalcamp.at
- MontenaSoft on DrupalCon 2009 in Paris, France
- How and why you should get Acquia Partnership – a presentation
- Press conference: Austrian Research Strategy 2020 officially introduced
- Drupal Media Camp in Aarau, Switzerland
- Switzerland here we come :)
Recent comments
- guys...really...
3 weeks 6 days ago - Ironic
10 weeks 6 days ago - Drupal is less secure, eh?
13 weeks 21 hours ago - There will be spam...
15 weeks 2 days ago - I would to thank Ignacio
18 weeks 9 hours ago - Apples & Oranges
21 weeks 1 day ago - There will be spam...
21 weeks 2 days ago - good for spam boots
21 weeks 6 days ago - Human SPAM?
21 weeks 6 days ago - hi Zeljko, thanks for the
32 weeks 3 days ago
Contact
MontenaSoft e.U.
Erne Seder Gasse 8/3/403
A-1030 Wien, Österreich
office (at) montenasoft (dot) com
www.montenasoft.com
tel: +43 (0) 699 19084898
fax:+43 (0) 1 91 6789 5


Comments
Post new comment